Talk:PPU registers: Difference between revisions
No edit summary |
m (My comment on the subject for usage of symbolic constants) |
||
Line 3: | Line 3: | ||
Personally I'd vote for removing references to those names from the Wiki but I don't want to force it if other people disagree. | Personally I'd vote for removing references to those names from the Wiki but I don't want to force it if other people disagree. | ||
Bregalad 21:29, 24 February 2010 (UTC) | Bregalad 21:29, 24 February 2010 (UTC) | ||
<br/> | |||
It depends. It's not only Tepples that promoted those names. I'm a firm believer that using symbolic constants makes the code easier to read. As long both are available in the wiki I don't see the issue. | |||
I can give you an example as code. Which one is clearer when you read back the code? | |||
This:<br/> | |||
lda #%1010000<br/> | |||
sta $2000<br/> | |||
Or: | |||
; In another file (nes.h)<br/> | |||
PPU_CTRL_NMI %10000000<br> | |||
PPU_CTRL_SPRITE8x16 %00100000<br/> | |||
PPU_CTRL $2000<br/> | |||
... | |||
; Somewhere in the code<br/> | |||
lda #PPU_CTRL_NMI + PPU_CTRL_SPRITE8x16<br/> | |||
sta PPU_CTRL<br/> | |||
Once you know the convention, it makes the code easier to read. Of course for the registers only it could be argued for a while since there is not that much on the nes but it's always good to follow good programming practice. In a professional environment, I will always promote the second once since it makes the code clearer. | |||
You don't know how many time I saw code samples for newb with no comments at all and you have to figure out what the hell was done with anonymous labels to make it worst. At the least those constants give some visual feedback on what you're trying to do. It's only a matter of getting used to the naming convention. | |||
In brief, I think it's a good practice to use them but nobody is forcing you do to so. There's just there to try to make a convention and of course not everyone will every with it (i.e. see how many linux distro..) | |||
[[User:Banshaku|Banshaku]] 01:35, 25 February 2010 (UTC) |
Revision as of 01:35, 25 February 2010
Am I the only one being annoyed by those "PPUMASK" "PPUSCROLL" etc... names ? Because Mr Tepples often refers them as it doesn't mean everyone often refers them as it. I like to use plain $2000, $2005, etc... Personally I'd vote for removing references to those names from the Wiki but I don't want to force it if other people disagree. Bregalad 21:29, 24 February 2010 (UTC)
It depends. It's not only Tepples that promoted those names. I'm a firm believer that using symbolic constants makes the code easier to read. As long both are available in the wiki I don't see the issue.
I can give you an example as code. Which one is clearer when you read back the code?
This:
lda #%1010000
sta $2000
Or:
- In another file (nes.h)
PPU_CTRL_NMI %10000000
PPU_CTRL_SPRITE8x16 %00100000
PPU_CTRL $2000
...
- Somewhere in the code
lda #PPU_CTRL_NMI + PPU_CTRL_SPRITE8x16
sta PPU_CTRL
Once you know the convention, it makes the code easier to read. Of course for the registers only it could be argued for a while since there is not that much on the nes but it's always good to follow good programming practice. In a professional environment, I will always promote the second once since it makes the code clearer.
You don't know how many time I saw code samples for newb with no comments at all and you have to figure out what the hell was done with anonymous labels to make it worst. At the least those constants give some visual feedback on what you're trying to do. It's only a matter of getting used to the naming convention.
In brief, I think it's a good practice to use them but nobody is forcing you do to so. There's just there to try to make a convention and of course not everyone will every with it (i.e. see how many linux distro..)
Banshaku 01:35, 25 February 2010 (UTC)